Messages in this thread | | | Date | Thu, 24 Sep 2015 09:17:16 +0800 | From | Peter Chen <> | Subject | Re: [PATCH v2 1/3] usb: chipidea: core: fix when building without CONFIG_PM support |
| |
On Wed, Sep 23, 2015 at 12:56:58PM +0100, Felipe F. Tonello wrote: > If CONFIG_PM or CONFIG_PM_SLEEP is not set, driver will not compile > properly. >
Would you post the warning or error messages?
I just tried at v4.3-rc1 (v4.2 should be same), without any problems.
Peter > Signed-off-by: Felipe F. Tonello <eu@felipetonello.com> > --- > > Changes for v2: > * removed unnecessary #ifdef CONFIG_PM_SLEEP. > > drivers/usb/chipidea/core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > index 3ad48e1..382b4af 100644 > --- a/drivers/usb/chipidea/core.c > +++ b/drivers/usb/chipidea/core.c > @@ -1009,18 +1009,20 @@ static int ci_runtime_resume(struct device *dev) > return ci_controller_resume(dev); > } > > -#endif /* CONFIG_PM */ > static const struct dev_pm_ops ci_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(ci_suspend, ci_resume) > SET_RUNTIME_PM_OPS(ci_runtime_suspend, ci_runtime_resume, NULL) > }; > +#endif /* CONFIG_PM */ > > static struct platform_driver ci_hdrc_driver = { > .probe = ci_hdrc_probe, > .remove = ci_hdrc_remove, > .driver = { > .name = "ci_hdrc", > +#ifdef CONFIG_PM > .pm = &ci_pm_ops, > +#endif > }, > }; > > -- > 2.1.4 >
--
Best Regards, Peter Chen
| |