lkml.org 
[lkml]   [2015]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management
Date
David Miller <davem@davemloft.net> writes:

> From: Robert Jarzmik <robert.jarzmik@free.fr>
> Date: Fri, 18 Sep 2015 18:36:56 +0200
>
>> Which brings me to wonder which is the more correct :
>> (a) replace to reproduce the same calculation
>> Previously mtt was compared to a difference of 76ns steps (as 307ns / 4 =
>> 76ns):
>> while ((sched_clock() - si->last_clk) * 76 < mtt)
>>
>> (b) change the calculation assuming mtt is in microseconds :
>> while ((sched_clock() - si->last_clk) * 1000 < mtt)
>>
>> I have no IRDA protocol knowledge so unless someone points me to the correct
>> calculation I'll try my luck with (b).
>
> "a" would be "safer" and less likely to break anything, although as
> you say "b" might be more correct.
Indeed.

Well, let me try (b) then. I'll add in the commit message the timings change,
and if anybody complains a regression pops out, I'll provide a patch to fallback
to (a).

Cheers.

--
Robert


\
 
 \ /
  Last update: 2015-09-22 21:41    [W:0.046 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site