lkml.org 
[lkml]   [2015]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected adapter
Date
On 9/21/15 9:14 PM, Jarod Wilson wrote:
> Just switching to adapter->io_addr everywhere seems to not work as
> noted above. :\ Note that I'm also chasing this from the other end
> with the author of the pci patches that seem to have triggered this,
> so the real bug might be over in pci-land, but hardening against
> explosions in igb still seems like a worthwhile effort here.

My understanding is that there can be problems if too many writes to a
removed device happen. That is why ixgbe avoids doing that by testing
for removal in some places. The io_addr does get used in the transmit
path simply to avoid adding a test to that hot path. That approach
seems to be working well for ixgbe.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-09-22 07:21    [W:0.236 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site