lkml.org 
[lkml]   [2015]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap
    From
    Date
    On 09/21/2015 02:26 PM, Mark Brown wrote:
    > On Mon, Sep 21, 2015 at 11:42:13AM -0500, Andrew F. Davis wrote:
    >
    >> I know this is hard to review, and so I would like to apologize in advance, but
    >> the regulator and GPIO changes depend on the new driver core, as do the i2c/spi
    >> components. I really don't know how to split this up without leaving some part
    >> in a non-working state in-between patches (which I've heard is also not OK).
    >
    > So split that interface change between the MFD and the function drivers
    > out into a separate change - you've got way more than just an interface
    > change in here (and you've not enumerated the various things that are
    > being changed in the changelog).
    >

    I'm not really "changing" anything, this is a ground-up re-write. This
    fundamentally changes the way the MFD core and the function drivers interact,
    I would consider this a whole new driver that just happens to replace an older
    driver, not a bunch of incremental changes although I kept the same filenames.


    \
     
     \ /
      Last update: 2015-09-21 22:01    [W:2.715 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site