lkml.org 
[lkml]   [2015]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] Staging: rts5208: Coding style warnings fix for block comments
    Date
    This patch is to the rtsx_transport.c that fixes up following warning
    reported by checkpatch.pl :

    -Block comments use * subsequent lines
    -Block comments use a trailing */ on a separate line

    Signed-off-by: Punit Vara <punitvara@gmail.com>
    ---
    drivers/staging/rts5208/rtsx_transport.c | 27 ++++++++++++++++++---------
    1 file changed, 18 insertions(+), 9 deletions(-)

    diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
    index f27491e..118fe0e 100644
    --- a/drivers/staging/rts5208/rtsx_transport.c
    +++ b/drivers/staging/rts5208/rtsx_transport.c
    @@ -36,7 +36,8 @@
    * For non-scatter-gather transfers, srb->request_buffer points to the
    * transfer buffer itself and srb->request_bufflen is the buffer's length.)
    * Update the *index and *offset variables so that the next copy will
    - * pick up from where this one left off. */
    + * pick up from where this one left off.
    + */

    unsigned int rtsx_stor_access_xfer_buf(unsigned char *buffer,
    unsigned int buflen, struct scsi_cmnd *srb, unsigned int *index,
    @@ -44,8 +45,10 @@ unsigned int rtsx_stor_access_xfer_buf(unsigned char *buffer,
    {
    unsigned int cnt;

    - /* If not using scatter-gather, just transfer the data directly.
    - * Make certain it will fit in the available buffer space. */
    + /*
    + * If not using scatter-gather, just transfer the data directly.
    + * Make certain it will fit in the available buffer space.
    + */
    if (scsi_sg_count(srb) == 0) {
    if (*offset >= scsi_bufflen(srb))
    return 0;
    @@ -58,22 +61,26 @@ unsigned int rtsx_stor_access_xfer_buf(unsigned char *buffer,
    *offset, cnt);
    *offset += cnt;

    - /* Using scatter-gather. We have to go through the list one entry
    + /*
    + * Using scatter-gather. We have to go through the list one entry
    * at a time. Each s-g entry contains some number of pages, and
    * each page has to be kmap()'ed separately. If the page is already
    * in kernel-addressable memory then kmap() will return its address.
    * If the page is not directly accessible -- such as a user buffer
    * located in high memory -- then kmap() will map it to a temporary
    - * position in the kernel's virtual address space. */
    + * position in the kernel's virtual address space.
    + */
    } else {
    struct scatterlist *sg =
    (struct scatterlist *) scsi_sglist(srb)
    + *index;

    - /* This loop handles a single s-g list entry, which may
    + /*
    + * This loop handles a single s-g list entry, which may
    * include multiple pages. Find the initial page structure
    * and the starting offset within the page, and update
    - * the *offset and *index values for the next loop. */
    + * the *offset and *index values for the next loop.
    + */
    cnt = 0;
    while (cnt < buflen && *index < scsi_sg_count(srb)) {
    struct page *page = sg_page(sg) +
    @@ -95,9 +102,11 @@ unsigned int rtsx_stor_access_xfer_buf(unsigned char *buffer,
    ++sg;
    }

    - /* Transfer the data for all the pages in this
    + /*
    + * Transfer the data for all the pages in this
    * s-g entry. For each page: call kmap(), do the
    - * transfer, and call kunmap() immediately after. */
    + * transfer, and call kunmap() immediately after.
    + */
    while (sglen > 0) {
    unsigned int plen = min(sglen, (unsigned int)
    PAGE_SIZE - poff);
    --
    2.5.2


    \
     
     \ /
      Last update: 2015-09-21 21:21    [W:5.547 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site