Messages in this thread | | | Date | Mon, 21 Sep 2015 13:40:34 -0400 | From | Tejun Heo <> | Subject | Re: [patch] devres: fix a for loop bounds check |
| |
On Mon, Sep 21, 2015 at 07:21:51PM +0300, Dan Carpenter wrote: > The iomap[] array has PCIM_IOMAP_MAX (6) elements and not > DEVICE_COUNT_RESOURCE (16). This bug was found using a static checker. > It may be that the "if (!(mask & (1 << i)))" check means we never > actually go past the end of the array in real life. > > Fixes: ec04b075843d ('iomap: implement pcim_iounmap_regions()') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |