lkml.org 
[lkml]   [2015]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/14] RFC: usb/host/fotg210: convert macro to inline function
    Date
    This patch convert the macro speed_char in an inline function. The goal
    of this patch is to make the code easier to read.

    Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
    ---
    drivers/usb/host/fotg210-hcd.c | 27 ++++++++++++++++-----------
    1 file changed, 16 insertions(+), 11 deletions(-)

    diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
    index 4032ed0..82cd5da 100644
    --- a/drivers/usb/host/fotg210-hcd.c
    +++ b/drivers/usb/host/fotg210-hcd.c
    @@ -331,17 +331,22 @@ struct debug_buffer {
    size_t alloc_size;
    };

    -#define speed_char(info1)({ char tmp; \
    - switch (info1 & (3 << 12)) { \
    - case QH_FULL_SPEED: \
    - tmp = 'f'; break; \
    - case QH_LOW_SPEED: \
    - tmp = 'l'; break; \
    - case QH_HIGH_SPEED: \
    - tmp = 'h'; break; \
    - default: \
    - tmp = '?'; break; \
    - } tmp; })
    +static inline char speed_char(u32 scratch)
    +{
    + switch (scratch & (3 << 12)) {
    + case QH_FULL_SPEED:
    + return 'f';
    +
    + case QH_LOW_SPEED:
    + return 'l';
    +
    + case QH_HIGH_SPEED:
    + return 'h';
    +
    + default:
    + return '?';
    + }
    +}

    static inline char token_mark(struct fotg210_hcd *fotg210, __hc32 token)
    {
    --
    2.1.0


    \
     
     \ /
      Last update: 2015-09-21 17:21    [W:4.396 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site