Messages in this thread | | | Date | Mon, 21 Sep 2015 12:18:26 +0200 | From | Olaf Hering <> | Subject | Re: [PATCH 4/5] hv: kvp: use wrappers to propaigate state |
| |
On Sun, Sep 20, Greg KH wrote:
> On Tue, Sep 15, 2015 at 05:37:53PM -0700, K. Y. Srinivasan wrote: > > @@ -122,8 +125,8 @@ static void kvp_timeout_func(struct work_struct *dummy)
> > + if (kvp_get_state() > HVUTIL_READY) > > + kvp_set_state(HVUTIL_READY);
> And what if the state changed the line after this? Oops, your code is > hosed. See, you need a lock, do this correctly.
KY, can this happen?
Olaf
| |