Messages in this thread | | | Date | Wed, 2 Sep 2015 10:14:56 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v4 5/5] sched: add two functions for att(det)aching a task to(from) a cfs_rq |
| |
On Wed, Sep 02, 2015 at 11:33:15AM +0900, Byungchul Park wrote: > +++ b/kernel/sched/fair.c > @@ -7920,14 +7920,14 @@ prio_changed_fair(struct rq *rq, struct task_struct *p, int oldprio) > > static inline bool vruntime_normalized(struct task_struct *p) > { > struct sched_entity *se = &p->se; > > /* > + * In both TASK_ON_RQ_QUEUED case and TASK_ON_RQ_MIGRATING case, > + * the dequeue_entity(.flags=0) will already have normalized the > + * vruntime. > */ > + if (p->on_rq) > return true; >
You're right. And yes this is nicer. Thanks!
I've folded it into your 5/5 patch.
| |