Messages in this thread | | | From | Vince Weaver <> | Date | Wed, 2 Sep 2015 11:40:40 -0400 (EDT) | Subject | Re: perf: possible bug in perf_event__read_size |
| |
On Wed, 2 Sep 2015, Vince Weaver wrote: > Shouldn't that be > > if (event->attr.read_format & PERF_FORMAT_ID) > size += sizeof(u64);
never mind, after a lot of further thought I can see this is a "clever" hack to allow group events to have an ID for each value.
It's a shame the perf_event code doesn't more comments in the code, especially when the code is being clever like this.
Vince
| |