Messages in this thread | | | Date | Sat, 19 Sep 2015 15:35:05 +0200 | From | Jiri Olsa <> | Subject | Re: tools build: Unused function, incomplete rename |
| |
On Fri, Sep 18, 2015 at 04:23:34PM -0300, Arnaldo Carvalho de Melo wrote: > Hi Jiri, Ingo, > > While trying to figure out why the bpf feature test is always > triggering the display of the "Auto-detecting system features" I noticed > this pattern: > > [acme@felicio linux]$ egrep '^define|eval' tools/build/Makefile.feature > feature_check = $(eval $(feature_check_code)) > define feature_check_code > feature_set = $(eval $(feature_set_code)) > define feature_set_code > set_test_all_flags = $(eval $(set_test_all_flags_code)) > define set_test_all_flags_code > feature_print_status = $(eval $(feature_print_status_code)) $(info $(MSG)) > define feature_print_status_code > feature_print_text = $(eval $(feature_print_text_code)) $(info $(MSG)) > define feature_print_text_code > feature_display_check = $(eval $(feature_check_code)) > define feature_display_check_code > [acme@felicio linux]$ > > > In all but one case the eval matches the following define, except for the last > one, don't we need the following patch? > > $ git diff tools/build/Makefile.feature > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature > index 0caeaf2cae5f..072ec879b84f 100644 > --- a/tools/build/Makefile.feature > +++ b/tools/build/Makefile.feature > @@ -142,7 +142,7 @@ ifneq ("$(FEATURE_DUMP)","$(FEATURE_DUMP_FILE)") > feature_display := 1 > endif > > -feature_display_check = $(eval $(feature_check_code)) > +feature_display_check = $(eval $(feature_check_display_code)) > define feature_display_check_code > ifneq ($(feature-$(1)), 1) > feature_display := 1
ouch, that is a bug.. nice catch!
thanks, jirka
| |