lkml.org 
[lkml]   [2015]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2 100/120] spi/spi-xilinx: Fix mixed poll/irq mode
    Date
    4.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

    commit 16ea9b8ac45bf11d48af6013283e141e8ed86348 upstream.

    Once the module process a transfer in irq mode, the next poll transfer
    will not work because the transmitter is left in inhibited state.

    Fixes: 22417352f6b7f623 (Use polling mode on small transfers)
    Reported-by: Edward Kigwana <ekigwana@scires.com>
    Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/spi/spi-xilinx.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/spi/spi-xilinx.c
    +++ b/drivers/spi/spi-xilinx.c
    @@ -306,8 +306,10 @@ static int xilinx_spi_txrx_bufs(struct s
    remaining_words -= n_words;
    }

    - if (use_irq)
    + if (use_irq) {
    xspi->write_fn(0, xspi->regs + XIPIF_V123B_DGIER_OFFSET);
    + xspi->write_fn(cr, xspi->regs + XSPI_CR_OFFSET);
    + }

    return t->len;
    }



    \
     
     \ /
      Last update: 2015-09-19 20:01    [W:4.055 / U:0.584 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site