Messages in this thread Patch in this message | | | Date | Fri, 18 Sep 2015 16:38:42 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: tools build: Unused function, incomplete rename |
| |
Em Fri, Sep 18, 2015 at 04:23:34PM -0300, Arnaldo Carvalho de Melo escreveu: > Hi Jiri, Ingo, > > While trying to figure out why the bpf feature test is always > triggering the display of the "Auto-detecting system features" I noticed > this pattern:
Another problem, this time in how tools/lib/bpf/ specifies which features to test for and which ones should have the feature detection shown, does the following patch makes sense? I think it does because FEATURE_TESTS looks like the ones that will be tested, and FEATURE_DISPLAY the ones that will appear...:
diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile index f68d23a0b487..604c12081b4b 100644 --- a/tools/lib/bpf/Makefile +++ b/tools/lib/bpf/Makefile @@ -64,8 +64,8 @@ srctree := $(patsubst %/,%,$(dir $(srctree))) #$(info Determined 'srctree' to be $(srctree)) endif -FEATURE_DISPLAY = libelf libelf-getphdrnum libelf-mmap bpf -FEATURE_TESTS = libelf bpf +FEATURE_TESTS = libelf libelf-getphdrnum libelf-mmap bpf +FEATURE_DISPLAY = libelf bpf INCLUDES = -I. -I$(srctree)/tools/include -I$(srctree)/arch/$(ARCH)/include/uapi -I$(srctree)/include/uapi FEATURE_CHECK_CFLAGS-bpf = $(INCLUDES)
| |