Messages in this thread | | | Subject | Re: [PATCH] mm/oom_kill.c: don't kill TASK_UNINTERRUPTIBLE tasks | From | Tetsuo Handa <> | Date | Sat, 19 Sep 2015 01:39:53 +0900 |
| |
Oleg Nesterov wrote: > To simplify the discussion lets ignore PF_FROZEN, this is another issue. > > I am not sure this change is enough, we need to ensure that > select_bad_process() won't pick the same task (or its sub-thread) again.
SysRq-f is sometimes unusable because it continues choosing the same thread. oom_kill_process() should not choose a thread which already has TIF_MEMDIE. I think we need to rewrite oom_kill_process().
> > And perhaps something like > > wait_event_timeout(oom_victims_wait, !oom_victims, > configurable_timeout); > > before select_bad_process() makes sense?
I think you should not sleep for long with oom_lock mutex held. http://marc.info/?l=linux-mm&m=143031212312459
| |