Messages in this thread | | | From | Rob Herring <> | Date | Fri, 18 Sep 2015 09:24:42 -0500 | Subject | Re: [PATCH v2 2/2] of: changesets: Introduce changeset helper methods |
| |
On Fri, Sep 18, 2015 at 4:15 AM, Pantelis Antoniou <pantelis.antoniou@konsulko.com> wrote: > Hi Rob, > >> On Sep 17, 2015, at 17:13 , Rob Herring <robh@kernel.org> wrote: >> >> On 09/16/2015 11:11 AM, Pantelis Antoniou wrote: >>> Changesets are very powerful, but the lack of a helper API >>> makes using them cumbersome. Introduce a simple copy based >>> API that makes things considerably easier.
[...]
>>> +struct device_node *of_changeset_create_device_nodev( >>> + struct of_changeset *ocs, struct device_node *parent, >>> + const char *fmt, va_list vargs) >>> +{ >>> + struct device_node *node; >>> + >>> + node = __of_node_dupv(NULL, fmt, vargs); >>> + if (!node) >>> + return ERR_PTR(-ENOMEM); >>> + >>> + node->parent = parent; >>> + return node; >>> +} >> >> EXPORT_SYMBOL_GPL here and on others? >> > > Err, none of the others of_changeset* methods are exported right now. > Up to now it was all internal API; should I go ahead and put EXPORT_SYMBOL_GPL > to all the others as well?
Okay, NM then.
Rob
| |