Messages in this thread | | | Date | Fri, 18 Sep 2015 14:42:04 +0100 | From | Ian Abbott <> | Subject | Re: [PATCH] Staging: comedi: Fixed coding style issues in comedi.h |
| |
On 18/09/15 13:30, Punit Vara wrote: > This patch is to the comedi.h file that fixes up following type > of 42 warning in the file: > > -Blocking comments use a trailing */ on a separate line > -Block comments use * on subsequent lines > > Signed-off-by: Punit Vara <punitvara@gmail.com> > > --- > drivers/staging/comedi/comedi.h | 183 +++++++++++++++++++++++----------------- > 1 file changed, 107 insertions(+), 76 deletions(-) > > diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h > index 66edda1..4bc4b6c 100644 > --- a/drivers/staging/comedi/comedi.h > +++ b/drivers/staging/comedi/comedi.h > @@ -1,20 +1,20 @@ > -/* > - include/comedi.h (installed as /usr/include/comedi.h) > - header file for comedi > - > - COMEDI - Linux Control and Measurement Device Interface > - Copyright (C) 1998-2001 David A. Schleef <ds@schleef.org> > - > - This program is free software; you can redistribute it and/or modify > - it under the terms of the GNU Lesser General Public License as published by > - the Free Software Foundation; either version 2 of the License, or > - (at your option) any later version. > - > - This program is distributed in the hope that it will be useful, > - but WITHOUT ANY WARRANTY; without even the implied warranty of > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - GNU General Public License for more details. > -*/ > +/**
That's the wrong sort of comment opening. It should be '/*'. The '/**' form is reserved for kernel-doc mark-up.
> + * include/comedi.h (installed as /usr/include/comedi.h) > + * header file for comedi > +
These blank lines in the block comment should be ' *'.
(The same applies to the other comments you changed in this patch.)
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
| |