lkml.org 
[lkml]   [2015]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] ASoC: wm0010: disable regulator on error
On Fri, Sep 18, 2015 at 04:02:19PM +0530, Sudip Mukherjee wrote:
> We have done regulator_bulk_enable() while booting the DSP but on the
> error exit path we have not disbled it.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> sound/soc/codecs/wm0010.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
> index 8434d45..79a7cd3 100644
> --- a/sound/soc/codecs/wm0010.c
> +++ b/sound/soc/codecs/wm0010.c
> @@ -739,8 +739,6 @@ static int wm0010_boot(struct snd_soc_codec *codec)
> abort:
> /* Put the chip back into reset */
> wm0010_halt(codec);
> - mutex_unlock(&wm0010->lock);
> - return ret;

Does wm0010_halt not disable the regulators?

Thanks,
Charles

>
> err_core:
> mutex_unlock(&wm0010->lock);
> --
> 1.9.1


\
 
 \ /
  Last update: 2015-09-18 14:21    [W:0.051 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site