lkml.org 
[lkml]   [2015]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers)
Hello,

On Thu, Sep 17, 2015 at 09:48:37AM -0700, James Bottomley wrote:
> Well, there's an easy fix for that. We could have ida_remove() actually
> free the bitmap and not cache it if it's the last layer. That way ida
> would naturally empty and we wouldn't need a destructor. Tejun, would
> that work?

Yeah, that definitely is one way to go about it. It kinda muddles the
purpose of ida_destroy() tho. I suppose we can rename it to
idr_remove_all() and then do the same to idr. I'm not particularly
objecting to all that but what's wrong with just calling idr_destroy()
on exit paths? If missing the call in modules is an issue, maybe we
can just annotate idr/ida with debugobj?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2015-09-17 19:41    [W:0.069 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site