Messages in this thread | | | Subject | Re: [PATCH 0/3] x86/paravirt: Fix baremetal paravirt MSR ops | From | Paolo Bonzini <> | Date | Thu, 17 Sep 2015 17:29:01 +0200 |
| |
On 17/09/2015 17:27, Arjan van de Ven wrote: >> >>> ( We should double check that rdmsr()/wrmsr() results are never left >>> uninitialized, but are set to zero or so, for cases where the >>> return code is not >>> checked. ) >> >> It sure looks like native_read_msr_safe doesn't clear the output if >> the rdmsr fails. > > I'd suggest to return some poison not just 0...
What about 0 + WARN?
Paolo
> less likely to get interesting surprises that are insane hard to > debug/diagnose
| |