Messages in this thread | | | From | Peter Korsgaard <> | Subject | Re: [PATCH v2 3/7] hwrng: core: Simplify RNG switching from sysfs | Date | Thu, 17 Sep 2015 16:08:38 +0200 |
| |
>>>>> "Lee" == Lee Jones <lee.jones@linaro.org> writes:
> If we attempt to use sysfs to change the current RNG in the usual > way i.e. issuing something like:
> `echo 8a8a000.rng > /sys/devices/virtual/misc/hw_random/rng_current`
> ... it will fail because the code doesn't currently take the '\n' > into consideration. Well, now it does.
> Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/char/hw_random/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c > index da8faf7..2d4a969 100644 > --- a/drivers/char/hw_random/core.c > +++ b/drivers/char/hw_random/core.c > @@ -323,7 +323,7 @@ static ssize_t hwrng_attr_current_store(struct device *dev, > return -ERESTARTSYS; > err = -ENODEV; > list_for_each_entry(rng, &rng_list, list) { > - if (strcmp(rng->name, buf) == 0) { > + if (sysfs_streq(rng->name, buf)) {
Looks good.
Acked-by: Peter Korsgaard <peter@korsgaard.com>
-- Venlig hilsen, Peter Korsgaard
| |