lkml.org 
[lkml]   [2015]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf evlist: Remove redundant validation from propagate_maps()
    Commit-ID:  d5bc056e73841d4bc941474a342ef9b6a207ac84
    Gitweb: http://git.kernel.org/tip/d5bc056e73841d4bc941474a342ef9b6a207ac84
    Author: Adrian Hunter <adrian.hunter@intel.com>
    AuthorDate: Tue, 8 Sep 2015 10:58:51 +0300
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Tue, 15 Sep 2015 10:16:48 -0300

    perf evlist: Remove redundant validation from propagate_maps()

    The validation checks that the values that were just assigned, got
    assigned i.e. the error can't ever happen. Subsequent patches will call
    this code in places where errors are not being returned. Changing those
    code paths to return this non-existent error is counter-productive, so
    just remove it.

    That in turn results in perf_evlist__set_maps not needing to return an
    error, but callers aren't checking it either, so remove that too.

    Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
    Acked-by: Jiri Olsa <jolsa@kernel.org>
    Cc: Kan Liang <kan.liang@intel.com>
    Link: http://lkml.kernel.org/r/1441699142-18905-4-git-send-email-adrian.hunter@intel.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/evlist.c | 21 ++++++++-------------
    tools/perf/util/evlist.h | 5 ++---
    2 files changed, 10 insertions(+), 16 deletions(-)

    diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
    index 9cb9296..785bfd3 100644
    --- a/tools/perf/util/evlist.c
    +++ b/tools/perf/util/evlist.c
    @@ -1103,8 +1103,8 @@ int perf_evlist__mmap(struct perf_evlist *evlist, unsigned int pages,
    return perf_evlist__mmap_ex(evlist, pages, overwrite, 0, false);
    }

    -static int perf_evlist__propagate_maps(struct perf_evlist *evlist,
    - bool has_user_cpus)
    +static void perf_evlist__propagate_maps(struct perf_evlist *evlist,
    + bool has_user_cpus)
    {
    struct perf_evsel *evsel;

    @@ -1119,13 +1119,7 @@ static int perf_evlist__propagate_maps(struct perf_evlist *evlist,
    }

    evsel->threads = thread_map__get(evlist->threads);
    -
    - if ((evlist->cpus && !evsel->cpus) ||
    - (evlist->threads && !evsel->threads))
    - return -ENOMEM;
    }
    -
    - return 0;
    }

    int perf_evlist__create_maps(struct perf_evlist *evlist, struct target *target)
    @@ -1144,7 +1138,9 @@ int perf_evlist__create_maps(struct perf_evlist *evlist, struct target *target)
    if (evlist->cpus == NULL)
    goto out_delete_threads;

    - return perf_evlist__propagate_maps(evlist, !!target->cpu_list);
    + perf_evlist__propagate_maps(evlist, !!target->cpu_list);
    +
    + return 0;

    out_delete_threads:
    thread_map__put(evlist->threads);
    @@ -1152,9 +1148,8 @@ out_delete_threads:
    return -1;
    }

    -int perf_evlist__set_maps(struct perf_evlist *evlist,
    - struct cpu_map *cpus,
    - struct thread_map *threads)
    +void perf_evlist__set_maps(struct perf_evlist *evlist, struct cpu_map *cpus,
    + struct thread_map *threads)
    {
    cpu_map__put(evlist->cpus);
    evlist->cpus = cpus;
    @@ -1162,7 +1157,7 @@ int perf_evlist__set_maps(struct perf_evlist *evlist,
    thread_map__put(evlist->threads);
    evlist->threads = threads;

    - return perf_evlist__propagate_maps(evlist, false);
    + perf_evlist__propagate_maps(evlist, false);
    }

    int perf_evlist__apply_filters(struct perf_evlist *evlist, struct perf_evsel **err_evsel)
    diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
    index b39a619..da2fa91 100644
    --- a/tools/perf/util/evlist.h
    +++ b/tools/perf/util/evlist.h
    @@ -155,9 +155,8 @@ int perf_evlist__enable_event_idx(struct perf_evlist *evlist,
    void perf_evlist__set_selected(struct perf_evlist *evlist,
    struct perf_evsel *evsel);

    -int perf_evlist__set_maps(struct perf_evlist *evlist,
    - struct cpu_map *cpus,
    - struct thread_map *threads);
    +void perf_evlist__set_maps(struct perf_evlist *evlist, struct cpu_map *cpus,
    + struct thread_map *threads);
    int perf_evlist__create_maps(struct perf_evlist *evlist, struct target *target);
    int perf_evlist__apply_filters(struct perf_evlist *evlist, struct perf_evsel **err_evsel);


    \
     
     \ /
      Last update: 2015-09-16 10:01    [W:3.306 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site