lkml.org 
[lkml]   [2015]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest")
On 16/09/15 18:10, Jisheng Zhang wrote:
> Dear Thomas,
>
> On Thu, 17 Sep 2015 00:59:08 +0800
> Jisheng Zhang <jszhang@marvell.com> wrote:
>
>> On Wed, 16 Sep 2015 18:52:41 +0200
>> Thomas Gleixner <tglx@linutronix.de> wrote:
>>
>>> On Thu, 17 Sep 2015, Jisheng Zhang wrote:
>>>
>>>> Hi Marc,
>>>>
>>>> Commit 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a
>>>> guest") causes a regression on Marvell BG4CT SoC. In this SoC, there's only one
>>>> GIC, the secondary irq controller is Synopsys DW iCtl:
>>>> drivers/irqchip/irq-dw-apb-ictl.c
>>>>
>>>> So cascading_gic_irq() should return true on Marvell BG4CT SoC, but it returns
>>>> false. The logic in cascading_gic_irq() doesn't take cascaded irq controller
>>>> which is provided by non-gic controllers.
>>>
>>> I have a fix pending for this in
>>>
>>> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tmp.irq
>>>
>>> 714665351cc7: irqchip/gic: Use IRQD_FORWARDED_TO_VCPU flag
>>>
>>> Can you please give that a try?
>>
>> Sure, Will try and get back to you
>
> Good news! The regression is fixed, cascaded irq works again!
>
> Feel free to add
>
> Tested-by: Jisheng Zhang <jszhang@marvell.com>

Ah, excellent. Probably a case of handler_data being reused... Thanks a
lot for testing this!

M.
--
Jazz is not dead. It just smells funny...


\
 
 \ /
  Last update: 2015-09-16 19:41    [W:0.035 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site