lkml.org 
[lkml]   [2015]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH v8 0/4] can: Allwinner A10/A20 CAN Controller support - Summary
    Date
    Hi,

    please find attached the next version of my patch set. I have
    taken all remarks from Maxime Ripard into the new version

    Please review, test and report bugs if exists.

    The patchset applies to all recent Kernel versions (4.x, next etc.).

    [PATCH v8 1/4] Device Tree Binding Documentation
    [PATCH v8 2/4] Defconfig multi_v7
    [PATCH v8 3/4] Defconfig sunxi
    [PATCH v8 4/4] Kernel Module

    History:
    V8: sun4i_can.c: rename sunxi to sun4i
    dt: use sun4i-a10-can as identifier
    can_open: don't use shared IRQ

    v7: set_normal_mode: stripped (code inserted in can_stop)
    set_reset_mode: stripped (code inserted in can_start)
    sunxi_can_start: reworked
    sunxi_can_stop: function added
    sunxi_can_err: don't skip if skb alloc fails
    sunxican_bittiming_const: use netdev_dbg instead of netdev_info
    sunxican_probe: CAN_CTRLMODE_PRESUME_ACK

    v6: renamed the driver to sun4i as suggested by Maxime Ripard
    removed module version
    removed suspend and resume
    moved clk enable from can_start into open / should be balanced
    between enabling and disabling now
    freeing resources on error

    v5: fix license
    modify prefix to mode select defines
    enable and disable clock in sunxican_get_berr_counter
    delete set_normal_mode at the end of sunxi_can_start
    removed sunxican_id_table
    use devm_clk_get instead of clk_get
    use devm_ioremap_resource to simplify probe and remove
    make set-normal-mode and set-reset-mode more readable

    v4: defines prefixed with SUNXI_
    sunxi_can_write_cmdreg tweaked
    loops in set_xxx_mode reworked
    add return value to set_xxx_mode
    sunxican_start_xmit reworked
    struct platform_driver stripped
    moved set_bittiming into open
    moved clock start into open
    add clock stop to close
    suspend reworked
    resume reworked
    fixed double counting bug

    v3: changed error state change handling (thx Andri for the hint)
    use bittiming function correct (no need to call it)
    strip down priv (suggested by Marc)
    scripts/checkpatch.pl-> no matches anymore
    sparse -> no errors or warnings anymore
    v2: cleaning
    v1: initial

    Signed-off-by: Gerhard Bertelsmann <info@gerhard-bertelsmann.de>
    ---

    .../devicetree/bindings/net/can/sun4i_can.txt | 38 +
    arch/arm/configs/multi_v7_defconfig | 1 +
    arch/arm/configs/sunxi_defconfig | 2 +
    drivers/net/can/Kconfig | 10 +
    drivers/net/can/Makefile | 1 +
    drivers/net/can/sun4i_can.c | 857 +++++++++++++++++++++
    6 files changed, 909 insertions(+)


    \
     
     \ /
      Last update: 2015-09-16 13:41    [W:3.869 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site