lkml.org 
[lkml]   [2015]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its implementation
    From
    Date
    Ping.

    Regards
    Andrzej

    On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
    > The patch was generated using fixed coccinelle semantic patch
    > scripts/coccinelle/api/memdup.cocci [1].
    >
    > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
    >
    > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
    > ---
    > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +---
    > 1 file changed, 1 insertion(+), 3 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
    > index 8da6424..94bd992 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
    > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
    > @@ -549,12 +549,10 @@ int amdgpu_bo_set_metadata (struct amdgpu_bo *bo, void *metadata,
    > if (metadata == NULL)
    > return -EINVAL;
    >
    > - buffer = kzalloc(metadata_size, GFP_KERNEL);
    > + buffer = kmemdup(metadata, metadata_size, GFP_KERNEL);
    > if (buffer == NULL)
    > return -ENOMEM;
    >
    > - memcpy(buffer, metadata, metadata_size);
    > -
    > kfree(bo->metadata);
    > bo->metadata_flags = flags;
    > bo->metadata = buffer;



    \
     
     \ /
      Last update: 2015-09-16 12:21    [W:3.082 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site