lkml.org 
[lkml]   [2015]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [4.2] commit d59cfc09c32 (sched, cgroup: replace signal_struct->group_rwsem with a global percpu_rwsem) causes regression for libvirt/kvm
From
Date


On 16/09/2015 10:57, Christian Borntraeger wrote:
> Am 16.09.2015 um 10:32 schrieb Paolo Bonzini:
>>
>>
>> On 15/09/2015 19:38, Paul E. McKenney wrote:
>>> Excellent points!
>>>
>>> Other options in such situations include the following:
>>>
>>> o Rework so that the code uses call_rcu*() instead of *_expedited().
>>>
>>> o Maintain a per-task or per-CPU counter so that every so many
>>> *_expedited() invocations instead uses the non-expedited
>>> counterpart. (For example, synchronize_rcu instead of
>>> synchronize_rcu_expedited().)
>>
>> Or just use ratelimit (untested):
>
> One of my tests was to always replace synchronize_sched_expedited with
> synchronize_sched and things turned out to be even worse. Not sure if
> it makes sense to test yopur in-the-middle approach?

I don't think it applies here, since down_write/up_write is a
synchronous API.

If the revert isn't easy, I think backporting rcu_sync is the best bet.
The issue is that rcu_sync doesn't eliminate synchronize_sched, it only
makes it more rare. So it's possible that it isn't eliminating the root
cause of the problem.

Paolo


\
 
 \ /
  Last update: 2015-09-16 11:41    [W:0.125 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site