lkml.org 
[lkml]   [2015]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:irq/urgent] irqchip/GICv2m: Fix GICv2m build warning on 32 bits
    Commit-ID:  157add60cb35913b8a848a3d7e6456b8ed134796
    Gitweb: http://git.kernel.org/tip/157add60cb35913b8a848a3d7e6456b8ed134796
    Author: Pavel Fedin <p.fedin@samsung.com>
    AuthorDate: Sun, 13 Sep 2015 12:14:33 +0100
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitDate: Tue, 15 Sep 2015 17:06:29 +0200

    irqchip/GICv2m: Fix GICv2m build warning on 32 bits

    After GICv2m was enabled for 32-bit ARM kernel, a warning popped up:

    drivers/irqchip/irq-gic-v2m.c: In function gicv2m_compose_msi_msg:
    drivers/irqchip/irq-gic-v2m.c:100:2: warning: right shift count >= width
    of type [enabled by default]
    msg->address_hi = (u32) (addr >> 32);
    ^

    This patch fixes it by using proper macros for splitting up the value.

    Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
    Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>
    Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: Stuart Yoder <stuart.yoder@freescale.com>
    Cc: Jason Cooper <jason@lakedaemon.net>
    Link: http://lkml.kernel.org/r/1442142873-20213-4-git-send-email-marc.zyngier@arm.com
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    ---
    drivers/irqchip/irq-gic-v2m.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
    index db04fc1..12985da 100644
    --- a/drivers/irqchip/irq-gic-v2m.c
    +++ b/drivers/irqchip/irq-gic-v2m.c
    @@ -95,8 +95,8 @@ static void gicv2m_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
    struct v2m_data *v2m = irq_data_get_irq_chip_data(data);
    phys_addr_t addr = v2m->res.start + V2M_MSI_SETSPI_NS;

    - msg->address_hi = (u32) (addr >> 32);
    - msg->address_lo = (u32) (addr);
    + msg->address_hi = upper_32_bits(addr);
    + msg->address_lo = lower_32_bits(addr);
    msg->data = data->hwirq;
    }


    \
     
     \ /
      Last update: 2015-09-15 18:21    [W:3.221 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site