Messages in this thread Patch in this message | | | From | Jiri Slaby <> | Subject | [PATCH 3.12 27/33] bio: fix argument of __bio_add_page() for max_sectors > 0xffff | Date | Tue, 15 Sep 2015 16:22:22 +0200 |
| |
From: Akinobu Mita <akinobu.mita@gmail.com>
3.12-stable review patch. If anyone has any objections, please let me know.
===============
commit 34f2fd8dfe6185b0eaaf7d661281713a6170b077 upstream.
The data type of max_sectors and max_hw_sectors in queue settings are unsigned int. But these values are passed to __bio_add_page() as an argument whose data type is unsigned short. In the worst case such as max_sectors is 0x10000, bio_add_page() can't add a page and IOs can't proceed.
Cc: Jens Axboe <axboe@kernel.dk> Cc: Alexander Viro <viro@zeniv.linux.org.uk> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Jiri Slaby <jslaby@suse.cz> --- fs/bio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/bio.c b/fs/bio.c index ea5035da4d9a..e7fb3f82f5f5 100644 --- a/fs/bio.c +++ b/fs/bio.c @@ -601,7 +601,7 @@ EXPORT_SYMBOL(bio_get_nr_vecs); static int __bio_add_page(struct request_queue *q, struct bio *bio, struct page *page, unsigned int len, unsigned int offset, - unsigned short max_sectors) + unsigned int max_sectors) { int retried_segments = 0; struct bio_vec *bvec; -- 2.5.2
| |