| From | lizf@kernel ... | Subject | [PATCH 3.4 135/146] ipv4: Missing sk_nulls_node_init() in ping_unhash(). | Date | Tue, 15 Sep 2015 17:04:10 +0800 |
| |
From: "David S. Miller" <davem@davemloft.net>
3.4.109-rc1 review patch. If anyone has any objections, please let me know.
------------------
commit a134f083e79fb4c3d0a925691e732c56911b4326 upstream.
If we don't do that, then the poison value is left in the ->pprev backlink.
This can cause crashes if we do a disconnect, followed by a connect().
Tested-by: Linus Torvalds <torvalds@linux-foundation.org> Reported-by: Wen Xu <hotdog3645@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Zefan Li <lizefan@huawei.com> --- net/ipv4/ping.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c index cb90852..9f471c3 100644 --- a/net/ipv4/ping.c +++ b/net/ipv4/ping.c @@ -138,6 +138,7 @@ static void ping_v4_unhash(struct sock *sk) if (sk_hashed(sk)) { write_lock_bh(&ping_table.lock); hlist_nulls_del(&sk->sk_nulls_node); + sk_nulls_node_init(&sk->sk_nulls_node); sock_put(sk); isk->inet_num = 0; isk->inet_sport = 0; -- 1.9.1
|