lkml.org 
[lkml]   [2015]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 31/39] KVM: MMU: drop null test before destroy functions
From
Date


On 13/09/2015 14:15, Julia Lawall wrote:
> Remove unneeded NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@ expression x; @@
> -if (x != NULL)
> \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> arch/x86/kvm/mmu.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index 69088a1..fb0c1bd 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -4883,10 +4883,8 @@ static struct shrinker mmu_shrinker = {
>
> static void mmu_destroy_caches(void)
> {
> - if (pte_list_desc_cache)
> - kmem_cache_destroy(pte_list_desc_cache);
> - if (mmu_page_header_cache)
> - kmem_cache_destroy(mmu_page_header_cache);
> + kmem_cache_destroy(pte_list_desc_cache);
> + kmem_cache_destroy(mmu_page_header_cache);
> }
>
> int kvm_mmu_module_init(void)
>

Acked-by: Paolo Bonzini <pbonzini@redhat.com>


\
 
 \ /
  Last update: 2015-09-14 10:41    [W:0.359 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site