lkml.org 
[lkml]   [2015]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] staging/rtl8192u: remove unused function
2015-09-14 14:00 GMT-04:00 Nicolas Joseph <nicolas.joseph@homecomputing.fr>:
> Remove N_DBPSOfRate used in ComputeTxTime, remove by
> commit 742728f97a99 ("staging: rtl8192u: remove unused function.")
>
> Signed-off-by: Nicolas Joseph <nicolas.joseph@homecomputing.fr>
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 44 ----------------------------------
> 1 file changed, 44 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index b143b36..80a6a4f 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -1227,50 +1227,6 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
> return 0;
> }
>
> -u16 N_DBPSOfRate(u16 DataRate)
> -{
> - u16 N_DBPS = 24;
> -
> - switch (DataRate) {
> - case 60:
> - N_DBPS = 24;
> - break;
> -
> - case 90:
> - N_DBPS = 36;
> - break;
> -
> - case 120:
> - N_DBPS = 48;
> - break;
> -
> - case 180:
> - N_DBPS = 72;
> - break;
> -
> - case 240:
> - N_DBPS = 96;
> - break;
> -
> - case 360:
> - N_DBPS = 144;
> - break;
> -
> - case 480:
> - N_DBPS = 192;
> - break;
> -
> - case 540:
> - N_DBPS = 216;
> - break;
> -
> - default:
> - break;
> - }
> -
> - return N_DBPS;
> -}
> -
> short rtl819xU_tx_cmd(struct net_device *dev, struct sk_buff *skb)
> {
> struct r8192_priv *priv = ieee80211_priv(dev);
> --
> 2.5.2
>

Not sure the commit message is really clear. Something like this seems
more clean to me:
"Remove unused function N_DBPSOfRate. This function was only
used by function ComputeTxTime that was removed in a previous
commit."


\
 
 \ /
  Last update: 2015-09-14 21:01    [W:0.257 / U:1.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site