Messages in this thread | | | Date | Mon, 14 Sep 2015 12:00:41 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings |
| |
Hello, Arnd.
On Mon, Sep 14, 2015 at 09:45:33AM +0200, Arnd Bergmann wrote: > In general, we really want to leave drivers with a COMPILE_TEST dependency > so they at least get cross-built on x86, ideally on all architectures.
Yeah, as long as it doesn't trigger silly warnings or errors on x86, COMPILE_TEST is usually a good idea.
> Does something like the below help? I think we really just need to help > gcc a little to see the obvious.
We already tried cachine qoriq_priv->type in a local. Not sure this would make much difference. It looks like the warning goes away with newer gcc. I'm inclined to just leave it as-is.
Thanks.
-- tejun
| |