Messages in this thread | | | Date | Mon, 14 Sep 2015 10:19:18 -0400 | From | Jeff Layton <> | Subject | Re: [PATCH 3/4] fs: add fput_queue |
| |
On Mon, 14 Sep 2015 15:15:39 +0100 Al Viro <viro@ZenIV.linux.org.uk> wrote:
> On Mon, Sep 14, 2015 at 09:45:54AM -0400, Jeff Layton wrote: > > +/** > > + * fput_queue - do an fput without using task_work > > + * @file: file of which to put the reference > > + * > > + * If we need to ensure that the final __fput is done on a file before > > + * returning to userland, then we can't queue it to task_work. For that we > ????????? > > + * borrow the infrastructure used by kthreads, and the task can then just > > + * called flush_delayed_fput to ensure that the final fput has completed. > > Are you sure that it's not a typo?
I don't think so, but it could be clearer. Something like this maybe?
"then we can't queue it via task_work_add."
-- Jeff Layton <jlayton@poochiereds.net>
| |