lkml.org 
[lkml]   [2015]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 37/39] f2fs crypto: drop null test before destroy functions
    Date
    Remove unneeded NULL test.

    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @@ expression x; @@
    -if (x != NULL)
    \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    fs/f2fs/crypto.c | 9 +++------
    1 file changed, 3 insertions(+), 6 deletions(-)

    diff --git a/fs/f2fs/crypto.c b/fs/f2fs/crypto.c
    index 4a62ef1..3c27f04 100644
    --- a/fs/f2fs/crypto.c
    +++ b/fs/f2fs/crypto.c
    @@ -183,8 +183,7 @@ static void f2fs_crypto_destroy(void)
    list_for_each_entry_safe(pos, n, &f2fs_free_crypto_ctxs, free_list)
    kmem_cache_free(f2fs_crypto_ctx_cachep, pos);
    INIT_LIST_HEAD(&f2fs_free_crypto_ctxs);
    - if (f2fs_bounce_page_pool)
    - mempool_destroy(f2fs_bounce_page_pool);
    + mempool_destroy(f2fs_bounce_page_pool);
    f2fs_bounce_page_pool = NULL;
    }

    @@ -240,10 +239,8 @@ void f2fs_exit_crypto(void)

    if (f2fs_read_workqueue)
    destroy_workqueue(f2fs_read_workqueue);
    - if (f2fs_crypto_ctx_cachep)
    - kmem_cache_destroy(f2fs_crypto_ctx_cachep);
    - if (f2fs_crypt_info_cachep)
    - kmem_cache_destroy(f2fs_crypt_info_cachep);
    + kmem_cache_destroy(f2fs_crypto_ctx_cachep);
    + kmem_cache_destroy(f2fs_crypt_info_cachep);
    }

    int __init f2fs_init_crypto(void)


    \
     
     \ /
      Last update: 2015-09-13 14:41    [W:3.834 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site