lkml.org 
[lkml]   [2015]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] Staging: rtl8723au: Bool tests don't need comparisons
    Date
    This patch removes comparisons to true/false values on bool variables.
    Fixed using Coccinelle

    Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
    ---
    drivers/staging/rtl8723au/core/rtw_ap.c | 4 ++--
    drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 +-
    drivers/staging/rtl8723au/core/rtw_wlan_util.c | 2 +-
    drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 4 +++---
    drivers/staging/rtl8723au/hal/rtl8723au_recv.c | 2 +-
    drivers/staging/rtl8723au/hal/usb_halinit.c | 2 +-
    6 files changed, 9 insertions(+), 9 deletions(-)

    diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
    index 65b209a..bd1a306 100644
    --- a/drivers/staging/rtl8723au/core/rtw_ap.c
    +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
    @@ -409,7 +409,7 @@ void add_RATid23a(struct rtw_adapter *padapter, struct sta_info *psta, u8 rssi_l

    arg |= BIT(7);/* support entry 2~31 */

    - if (shortGIrate == true)
    + if (shortGIrate)
    arg |= BIT(5);

    tx_ra_bitmap |= ((raid<<28)&0xf0000000);
    @@ -424,7 +424,7 @@ void add_RATid23a(struct rtw_adapter *padapter, struct sta_info *psta, u8 rssi_l
    /* arg[5] = Short GI */
    rtl8723a_add_rateatid(padapter, tx_ra_bitmap, arg, rssi_level);

    - if (shortGIrate == true)
    + if (shortGIrate)
    init_rate |= BIT(6);

    /* set ra_id, init_rate */
    diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
    index be9a3d5..b22a698 100644
    --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
    +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
    @@ -4092,7 +4092,7 @@ static void rtw_site_survey(struct rtw_adapter *padapter)
    /* turn on dynamic functions */
    rtl8723a_odm_support_ability_restore(padapter);

    - if (is_client_associated_to_ap23a(padapter) == true)
    + if (is_client_associated_to_ap23a(padapter))
    issue_nulldata23a(padapter, NULL, 0, 3, 500);

    rtl8723a_mlme_sitesurvey(padapter, 0);
    diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c b/drivers/staging/rtl8723au/core/rtw_wlan_util.c
    index 3c1315fc..208b24d 100644
    --- a/drivers/staging/rtl8723au/core/rtw_wlan_util.c
    +++ b/drivers/staging/rtl8723au/core/rtw_wlan_util.c
    @@ -231,7 +231,7 @@ static unsigned int ratetbl2rateset(struct rtw_adapter *padapter,
    default:
    rate = ratetbl_val_2wifirate(rate);

    - if (is_basicrate(padapter, rate) == true)
    + if (is_basicrate(padapter, rate))
    rate |= IEEE80211_BASIC_RATE_MASK;

    rateset[len] = rate;
    diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
    index cf15f80..503231c 100644
    --- a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
    +++ b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
    @@ -5192,7 +5192,7 @@ static void btdm_NotifyFwScan(struct rtw_adapter *padapter, u8 scanType)
    {
    u8 H2C_Parameter[1] = {0};

    - if (scanType == true)
    + if (scanType)
    H2C_Parameter[0] = 0x1;

    RTPRINT(FBT, BT_TRACE, ("[BTCoex], Notify FW for wifi scan, write 0x3b = 0x%02x\n",
    @@ -9141,7 +9141,7 @@ u8 BTDM_IsWifiConnectionExist(struct rtw_adapter *padapter)
    if (BTHCI_HsConnectionEstablished(padapter))
    bRet = true;

    - if (check_fwstate(&padapter->mlmepriv, WIFI_ASOC_STATE) == true)
    + if (check_fwstate(&padapter->mlmepriv, WIFI_ASOC_STATE))
    bRet = true;

    return bRet;
    diff --git a/drivers/staging/rtl8723au/hal/rtl8723au_recv.c b/drivers/staging/rtl8723au/hal/rtl8723au_recv.c
    index 0fec84b..7acd8ae 100644
    --- a/drivers/staging/rtl8723au/hal/rtl8723au_recv.c
    +++ b/drivers/staging/rtl8723au/hal/rtl8723au_recv.c
    @@ -231,7 +231,7 @@ void update_recvframe_phyinfo(struct recv_frame *precvframe,

    pkt_info.StationID = 0xFF;
    if (pkt_info.bPacketBeacon) {
    - if (check_fwstate(&padapter->mlmepriv, WIFI_STATION_STATE) == true)
    + if (check_fwstate(&padapter->mlmepriv, WIFI_STATION_STATE))
    sa = padapter->mlmepriv.cur_network.network.MacAddress;
    /* to do Ad-hoc */
    } else {
    diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c
    index 9926b07..f2d3f54 100644
    --- a/drivers/staging/rtl8723au/hal/usb_halinit.c
    +++ b/drivers/staging/rtl8723au/hal/usb_halinit.c
    @@ -1256,7 +1256,7 @@ void rtl8723a_update_ramask(struct rtw_adapter *padapter,
    arg = mac_id & 0x1f;/* MACID */
    arg |= BIT(7);

    - if (shortGIrate == true)
    + if (shortGIrate)
    arg |= BIT(5);

    DBG_8723A("update raid entry, mask = 0x%x, arg = 0x%x\n", mask, arg);
    --
    2.1.4


    \
     
     \ /
      Last update: 2015-09-12 08:01    [W:7.549 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site