Messages in this thread | | | Date | Fri, 11 Sep 2015 14:03:03 -0400 | From | "Raj, Ashok" <> | Subject | Re: [Patch V1] x86, mce: CPU synchronization for broadcast MCE's is surprised by offline CPUs |
| |
Hi Boris
On Fri, Sep 11, 2015 at 10:46:36AM +0200, Borislav Petkov wrote: > > One more buffer for MCEs? Why? > > We did add the mce_gen_pool thing exactly for logging stuff in atomic > context. From looking at the code, we probably could get rid of that > "struct mce_log mcelog" thing too and use only the gen_pool for logging > MCEs.
I think using gen_pool should be fine. Also seems the notify moved to the mce_gen_pool_process(), so there should be no notifier calls from the offline cpu.
Let me take a respin and resend. I should have noticed.. apologies.
> > We can then get rid of that MCE_LOG_LEN arbitrary 32 records and use > a nice 2-paged buffer which can be enlarged transparently later, if > needed.
| |