lkml.org 
[lkml]   [2015]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 01/22] driver core: Add pre_probe callback to bus_type
On Mon, Sep 07, 2015 at 02:23:26PM +0200, Tomeu Vizoso wrote:

> + if (dev->bus && dev->bus->pre_probe) {
> + ret = dev->bus->pre_probe(dev);
> + if (ret) {
> + if (ret == -EPROBE_DEFER)
> + driver_deferred_probe_add(dev);
> + ret = 0;
> + goto out_unlock;
> + }
> + }

So if we get an error other than -EPROBE_DEFER we silently ignore it?
That seems surprising and at least worth a comment.

> + if (dev->bus && dev->bus->pre_probe) {
> + ret = dev->bus->pre_probe(dev);
> + if (ret) {
> + if (ret == -EPROBE_DEFER)
> + driver_deferred_probe_add(dev);
> + goto out;
> + }
> + }

That's more what I'd expect.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-09-11 14:21    [W:4.238 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site