Messages in this thread | | | Date | Fri, 11 Sep 2015 13:04:08 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v4 01/22] driver core: Add pre_probe callback to bus_type |
| |
On Mon, Sep 07, 2015 at 02:23:26PM +0200, Tomeu Vizoso wrote:
> + if (dev->bus && dev->bus->pre_probe) { > + ret = dev->bus->pre_probe(dev); > + if (ret) { > + if (ret == -EPROBE_DEFER) > + driver_deferred_probe_add(dev); > + ret = 0; > + goto out_unlock; > + } > + }
So if we get an error other than -EPROBE_DEFER we silently ignore it? That seems surprising and at least worth a comment.
> + if (dev->bus && dev->bus->pre_probe) { > + ret = dev->bus->pre_probe(dev); > + if (ret) { > + if (ret == -EPROBE_DEFER) > + driver_deferred_probe_add(dev); > + goto out; > + } > + }
That's more what I'd expect. [unhandled content-type:application/pgp-signature] | |