Messages in this thread | | | Date | Fri, 11 Sep 2015 12:19:35 +0200 | From | Cornelia Huck <> | Subject | Re: [PATCH V4 2/4] kvm: fix double free for fast mmio eventfd |
| |
On Fri, 11 Sep 2015 17:25:45 +0800 Jason Wang <jasowang@redhat.com> wrote:
> On 09/11/2015 03:46 PM, Cornelia Huck wrote: > > On Fri, 11 Sep 2015 11:17:35 +0800 > > Jason Wang <jasowang@redhat.com> wrote:
> >> + > >> + /* When length is ignored, MMIO is also put on a separate bus, for > >> + * faster lookups. > >> + */ > >> + if (!args->len && !(args->flags & KVM_IOEVENTFD_FLAG_PIO)) { > > Dito on a positive check for bus_idx == KVM_MMIO_BUS. > > I was thinking maybe this should be done in a separate patch on top. > What's your opinion?
The check is an independent issue, an extra patch is fine (current usage does not trigger any problems).
> > >> + ret = kvm_assign_ioeventfd_idx(kvm, KVM_FAST_MMIO_BUS, args); > >> + if (ret < 0) > >> + goto fast_fail; > >> + }
| |