lkml.org 
[lkml]   [2015]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only
    On Thu, 10 Sep 2015 11:23:12 +0200
    Laurent Vivier <lvivier@redhat.com> wrote:

    > The value of the parameter is never re-read by the driver,
    > so a new value is ignored. Let know the user he
    > can't modify it by removing writable attribute.
    >
    > Signed-off-by: Laurent Vivier <lvivier@redhat.com>

    Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

    > ---
    > I resend this patch as James was not cc'ed.
    >
    > drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
    > index 6a41c36..3e76490 100644
    > --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
    > +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
    > @@ -105,9 +105,9 @@ MODULE_AUTHOR("Dave Boutcher");
    > MODULE_LICENSE("GPL");
    > MODULE_VERSION(IBMVSCSI_VERSION);
    >
    > -module_param_named(max_id, max_id, int, S_IRUGO | S_IWUSR);
    > +module_param_named(max_id, max_id, int, S_IRUGO);
    > MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
    > -module_param_named(max_channel, max_channel, int, S_IRUGO | S_IWUSR);
    > +module_param_named(max_channel, max_channel, int, S_IRUGO);
    > MODULE_PARM_DESC(max_channel, "Largest channel value");
    > module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
    > MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
    > --
    > 2.1.0
    >


    --
    David Gibson <dgibson@redhat.com>
    Senior Software Engineer, Virtualization, Red Hat
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2015-09-11 03:21    [W:4.198 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site