Messages in this thread | | | Date | Thu, 10 Sep 2015 12:30:18 +0200 | From | Robert Baldyga <> | Subject | Re: [PATCH 2/3] serial: samsung: remove unneded 'ignore_char' label |
| |
On 09/10/2015 02:27 AM, Krzysztof Kozlowski wrote: > On 08.09.2015 18:38, Robert Baldyga wrote: >> This label does nothing special and we don't need to have it anymore. >> >> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com> >> --- >> drivers/tty/serial/samsung.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) > > Label does nothing but it has a meaning. It serves as a comment - ignore > the character. So maybe: > > - goto ignore_char; > + continue; /* Ignore character */ > > What do you think?
Look good to me.
Thanks, Robert
| |