lkml.org 
[lkml]   [2015]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf, tools: Always use non inlined file name for srcfile
On Tue, Sep 01, 2015 at 03:36:57PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Sep 01, 2015 at 11:11:42AM -0700, Andi Kleen escreveu:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > When profiling the kernel with srcfile it's common to "get
> > stuck" in include. For example a lot of code uses current
> > or other inlines, so they get accounted to some random
> > include file. This is not very useful as a high level
> > categorization.
>
> Cool idea :-)

Yes.

It would be also nice to use this information for unwinding
(so to show the inline stack as part of the call graph)

> Why not the so much simpler:
>
> while (bfd_find_inliner_info(...));
>
> But other than that, wouldn't be better to put an upper limit on this?
>
> Say, 1024 levels of unwinding to avoid tripping in some bfd lib bug that
> could make this function always return true and make addr2line get stuck
> in an infinite loop?

Done. I sent a v2.

-Andi

--
ak@linux.intel.com -- Speaking for myself only


\
 
 \ /
  Last update: 2015-09-01 21:01    [W:0.084 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site