Messages in this thread | | | Date | Tue, 1 Sep 2015 11:04:54 -0700 | From | Stephen Boyd <> | Subject | Re: [PATCH 3/3] soc: qcom: smd: Handle big endian CPUs |
| |
On 08/31, Bjorn Andersson wrote: > On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote: > > > The smd structures are always in little endian, but the smd > > driver is not capable of being used on big endian CPUs. Annotate > > the little endian data members and update the code to do the > > proper byte swapping. > > > > I think this looks good, but I think it would be better to reference > the 8-bit entries of the info struct as "flags" rather than INFO8s. > > Could you please change the name of the macros to > {G,S}ET_{R,T}X_CHANNEL_FLAG() to make the code slightly easier to
Sure. I also found another missing __le32 marking on the "hdr" stack structure. I'll test out some smd sending before resending the patches.
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |