Messages in this thread | | | Date | Sat, 8 Aug 2015 23:41:28 -0700 | From | Christoph Hellwig <> | Subject | Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios |
| |
On Sat, Aug 08, 2015 at 10:59:50PM -0700, Ming Lin wrote: > +/* > + * Ensure that max discard sectors doesn't overflow bi_size and hopefully > + * it is of the proper granularity as long as the granularity is a power > + * of two. > + */ > +#define MAX_DISCARD_SECTORS ((1U << 31) >> 9)
Thisn't isn't MAX_DISCARD_SECTORS, it's MAX_BIO_SECTORS. If we ever to something like Kent's multipage biovecs we'll actually need it for regular read/write bios in addition to discard and write same.
Except for that the patch looks reasonable to me.
| |