lkml.org 
[lkml]   [2015]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.1 019/123] can: rcar_can: print signed IRQ #
    Date
    4.1-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

    commit c1a4c87b06fa564d6e2760a12d4e5a09badc684b upstream.

    Printing IRQ # using "%x" and "%u" unsigned formats isn't quite correct as
    'ndev->irq' is of type *int*, so the "%d" format needs to be used instead.

    While fixing this, beautify the dev_info() message in rcar_can_probe() a bit.

    Fixes: fd1159318e55 ("can: add Renesas R-Car CAN driver")
    Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/can/rcar_can.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/can/rcar_can.c
    +++ b/drivers/net/can/rcar_can.c
    @@ -526,7 +526,7 @@ static int rcar_can_open(struct net_devi
    napi_enable(&priv->napi);
    err = request_irq(ndev->irq, rcar_can_interrupt, 0, ndev->name, ndev);
    if (err) {
    - netdev_err(ndev, "error requesting interrupt %x\n", ndev->irq);
    + netdev_err(ndev, "error requesting interrupt %d\n", ndev->irq);
    goto out_close;
    }
    can_led_event(ndev, CAN_LED_EVENT_OPEN);
    @@ -824,7 +824,7 @@ static int rcar_can_probe(struct platfor

    devm_can_led_init(ndev);

    - dev_info(&pdev->dev, "device registered (reg_base=%p, irq=%u)\n",
    + dev_info(&pdev->dev, "device registered (regs @ %p, IRQ%d)\n",
    priv->regs, ndev->irq);

    return 0;



    \
     
     \ /
      Last update: 2015-08-09 00:41    [W:4.712 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site