lkml.org 
[lkml]   [2015]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/3] iTCO_wdt: Add support for TCO on Intel Sunrisepoint
On Thu, Aug 06, 2015 at 01:00:24PM +0100, Matt Fleming wrote:
> (Sorry for the delay in replying)
>
> On Fri, 31 Jul, at 11:41:04AM, Andy Shevchenko wrote:
> > >
> > > + if (val32 & enable_bit)
> > > + ret = -EIO;
> > > +
> > > return ret; /* returns: 0 = OK, -EIO = Error */
> >
> > What about removing ret at all?
> >
> > if (val32 & enable_bit)
> > return -EIO;
> >
> > return 0;
>
> Yeah, good catch. I'll make this change.

I'd go for the ternary operator here.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-08-06 23:21    [W:0.047 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site