Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [patch 2/7] x86/lguest: Do not setup unused irq vectors | Date | Tue, 04 Aug 2015 13:57:07 +0930 |
| |
Thomas Gleixner <tglx@linutronix.de> writes: > On Mon, 3 Aug 2015, Rusty Russell wrote: >> Thomas Gleixner <tglx@linutronix.de> writes: >> > + >> > + /* Some systems map "vectors" to interrupts weirdly. Not us! */ >> > + __this_cpu_write(vector_irq[FIRST_EXTERNAL_VECTOR + irq, irq); >> >> Missing ]. > > Doh. > >> [ 17.751889] do_IRQ: 0.33 No irq handler for vector (irq -1) >> >> You broke interrupts :( > > Right, because I missed the other place which fiddles with > interrupts. Does the patch below fix the issue?
Yep. I added error handling.
I reworked it into two patches: one which staticizes lguest_setup_irq() and moves it up, the other of which applies your changes.
Will post, you can take them...
Thanks, Rusty.
| |