Messages in this thread | | | Date | Sun, 30 Aug 2015 15:47:17 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH 2/3] rhashtable-test: retry insert operations in threads |
| |
Phil Sutter <phil@nwl.cc> wrote: > > Should we introduce a new field to struct rhashtable to track the > internal state? This might allow to clean up some rather obscure tests, > e.g. whether a table resize is in progress or not.
Why would we want to do that? The deferred expansion is done on a best effort basis so its failure has nothing to do with the failure of a subsequent insertion.
The insertion must have tried its own last-ditch synchronous expansion and only fail if that fails.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |