Messages in this thread | | | Date | Tue, 4 Aug 2015 02:41:11 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 2/4] perf, tools, stat: Abstract stat metrics printing |
| |
> > because we already need to make the print_metric callback global, > would it be better to make this struct global, having all the > needed callbacks defined within? something like:
It's actually not global, but static.
I skipped this change. After some other changes there is only a single function call with these arguments left, so it's not an issue to pass it around.
-Andi
| |