lkml.org 
[lkml]   [2015]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl
From
Date
On Mon, 2015-08-03 at 15:09 +0300, Dan Carpenter wrote:
> On Mon, Aug 03, 2015 at 04:41:40AM -0700, Joe Perches wrote:
> > On Mon, 2015-08-03 at 14:33 +0300, Dan Carpenter wrote:
> > > On Mon, Aug 03, 2015 at 11:18:31AM +0000, Shah, Yash (Y.) wrote:
> > > > From: Yash Shah <yshah1@visteon.com>
> > > >
> > > > Fixed code indentation warning as detected by checkpatch.pl.
> > > >
> > > > Signed-off-by: Yash Shah <yshah1@visteon.com>
> > >
> > > Defines aren't allowed in .c files anyway.
> >
> > The kernel source tree disagrees with you
> >
> > $ git grep "^\s*#\s*define\b" -- "*.c" | wc -l
> > 175830
>
> Duh. Sorry. I meant ifdefs. I'm sure you can find lots of examples
> of those too,

Yeah, no worries, only about 30k of those.

> but this code would be cleaner without the ifdefs.

Very true. Removing these would be good.


\
 
 \ /
  Last update: 2015-08-03 14:41    [W:0.040 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site