Messages in this thread | | | Date | Fri, 28 Aug 2015 07:25:00 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 11/11] x86, fpu: check CPU-provided sizes against struct declarations |
| |
* Dave Hansen <dave@sr71.net> wrote:
> @@ -447,6 +492,14 @@ static void do_extra_xstate_size_checks( > paranoid_xstate_size += xfeature_size(i); > } > XSTATE_WARN_ON(paranoid_xstate_size != xstate_size); > + /* > + * Basically, make sure that XSTATE_RESERVE has forced > + * xregs_state to be large enough. This is not fatal > + * because we reserve a *lot* of extra room in the init > + * task struct, but we should at least know we got it > + * wrong. > + */ > + XSTATE_WARN_ON(xstate_size > sizeof(struct xregs_state));
So do we need to warn about this? arch_task_struct_size is already dynamic today.
The only problem would be the init task, which is allocated statically - can we fix that?
Thanks,
Ingo
| |