lkml.org 
[lkml]   [2015]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] cred: Remove unnecessary kdebug atomic reads
Date
Andrew Morton <akpm@linux-foundation.org> wrote:

> Did you consider doing this within no_printk()? That would break code
> which is relying on side-effects in the evaluation of a printk arg but
> that's pretty weird and I bet there isn't (and won't be) such code.

The reasons that no_printk() is like it is are (1) so that the side-effects
stay intact and (2) you still get format warnings. If someone prints a device
register, for example, it *must* work the same whether or not you use printk()
or no_printk(). Of course, printing a device register like this is probably
not a good idea...

David


\
 
 \ /
  Last update: 2015-08-26 01:41    [W:0.056 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site